feat(rpc): Add top events support #81217
Merged
+353
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Nov 22, 2024
•
wmak
commented
- This allows the usage of top_events with the useRpc param
- This allows the usage of top_events with the useRpc param
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81217 +/- ##
==========================================
+ Coverage 80.35% 80.36% +0.01%
==========================================
Files 7219 7218 -1
Lines 319567 319540 -27
Branches 20769 20744 -25
==========================================
+ Hits 256780 256801 +21
+ Misses 62393 62347 -46
+ Partials 394 392 -2 |
Zylphrex
approved these changes
Nov 26, 2024
src/sentry/search/eap/spans.py
Outdated
| @@ -259,6 +224,40 @@ def _resolve_terms(self, terms: event_filter.ParsedTerms) -> TraceItemFilter | N | |||
| else: | |||
| return None | |||
|
|
|||
| def resolve_term(self, term: event_search.SearchFilter) -> TraceItemFilter | None: | |||
There was a problem hiding this comment.
This doesnt look like it can return None right?
There was a problem hiding this comment.
Good catch, that cleans up typing a bit
Comment on lines
+277
to
+278
| rpc_response = snuba_rpc.timeseries_rpc(rpc_request) | ||
| other_response = snuba_rpc.timeseries_rpc(other_request) |
There was a problem hiding this comment.
Should we have a way to run these queries in parallel?
There was a problem hiding this comment.
True i'll add that in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.