-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eap): Adds enabled prop to SpanTagsProvider #81188
feat(eap): Adds enabled prop to SpanTagsProvider #81188
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81188 +/- ##
==========================================
+ Coverage 80.33% 80.36% +0.02%
==========================================
Files 7223 7217 -6
Lines 320122 320031 -91
Branches 20779 20775 -4
==========================================
+ Hits 257174 257194 +20
+ Misses 62553 62443 -110
+ Partials 395 394 -1 |
const {data: indexedTags} = useSpanFieldCustomTags({ | ||
enabled: dataset === DiscoverDatasets.SPANS_INDEXED, | ||
enabled: dataset === DiscoverDatasets.SPANS_INDEXED && enabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: if you're concerned about undefined being passed through here unexpected, you could always rewrite it as enabled ? dataset === DiscoverDatasets.SPAN_INDEXED : false
and so on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 going to leave as is for now, since undefined
is a valid default value for useSpanFieldCustomTags
if we want. But also enabled
is required now anyways so we won't run into this scenario.
Bundle ReportChanges will increase total bundle size by 16.32kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Adds an
enabled
prop toSpanTagsProvider
to control fetching tags