Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Use rpc layer behind toggle #81182

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Zylphrex
Copy link
Member

This adds the RPC layer behind the dataset toggle (which is feature flagged) so that we can start testing RPC calls.

This adds the RPC layer behind the dataset toggle (which is feature flagged) so
that we can start testing RPC calls.
@Zylphrex Zylphrex requested a review from a team as a code owner November 22, 2024 16:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/explore/hooks/useDataset.tsx 50.00% 2 Missing ⚠️
static/app/views/explore/tables/spansTable.tsx 0.00% 2 Missing ⚠️
static/app/utils/discover/eventView.tsx 50.00% 0 Missing and 1 partial ⚠️
...tatic/app/views/explore/tables/aggregatesTable.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81182      +/-   ##
==========================================
- Coverage   80.33%   80.33%   -0.01%     
==========================================
  Files        7223     7223              
  Lines      320112   320124      +12     
  Branches    20779    20781       +2     
==========================================
+ Hits       257170   257179       +9     
- Misses      62549    62551       +2     
- Partials      393      394       +1     

Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Zylphrex Zylphrex merged commit 2b6ac4a into master Nov 22, 2024
43 of 44 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/use-rpc-layer-behind-toggle branch November 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants