Refactoring tracing span activation/deactivation #700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoumanAsh
force-pushed
the
tracing_span_to_tx_mapping
branch
from
42e2618
to
9e5a2ef
Compare
|
Closed because #686 already fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposal how to improve tracing layer to handle concurrency better
This changes logic of transaction activation/deactivation from being tied to ctor/dtor and instead tied to enter/exit
The reason being is that if you have multiple transactions running concurrently, there is no way to distinguish for sentry this scenario as it just creates new child transaction every time parent is present
Partially Fixes #675