Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AutoInstallStrategy for sentry-graphql-22 #781

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Oct 28, 2024

📜 Description

Add Auto-Install strategy for graphql-22

💡 Motivation and Context

Fixes getsentry/sentry-java#3756

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0716695

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should wait for v8 final release before merging, or do a beta release of the plugin


// prior versions could cause circular dependencies
// due to having graphql as implementation dependency
override val minSupportedSentryVersion: SemVer get() = SemVer(8, 0, 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the comment above

@lbloder lbloder marked this pull request as ready for review November 4, 2024 10:11
@adinauer adinauer merged commit 4bfea01 into main Nov 20, 2024
21 checks passed
@adinauer adinauer deleted the feat/graphql-22-auto-install branch November 20, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sentry-graphql-22 in auto install gradle plugin
3 participants