fix(pattern): Handle empty alternates #4277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the logic of the pattern parser so
that an empty alternate matches the empty string.
For example, the pattern `"foo{,/}"` now matches
both `"foo"` and `"foo/"` where before it would
only match `"foo/"` (because the empty part before
the comma was discarded.
Dav1dde
reviewed
Nov 21, 2024
Co-authored-by: David Herberth <[email protected]>
Dav1dde
previously approved these changes
Nov 22, 2024
|
As discussed in #4282, instead of smuggling in an empty literal in an alternate, we can instead transform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic of the pattern parser so that an empty alternate matches the empty string. For example, the pattern
"foo{,/}"now matches both"foo"and"foo/"where before it would only match"foo/"(because the empty part before the comma was discarded).