Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): Move tracing to only spans #179

Merged
merged 3 commits into from
May 2, 2024
Merged

feat(backend): Move tracing to only spans #179

merged 3 commits into from
May 2, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented May 2, 2024

No description provided.

@cleptric cleptric requested a review from a team as a code owner May 2, 2024 17:17
@cleptric cleptric self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 26.13%. Comparing base (2b6c142) to head (174180e).

Files Patch % Lines
src/Http/Client.php 80.95% 4 Missing ⚠️
src/Database/Log/SentryQueryLogger.php 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #179      +/-   ##
============================================
- Coverage     26.57%   26.13%   -0.44%     
+ Complexity      293      289       -4     
============================================
  Files            73       73              
  Lines          2965     2942      -23     
============================================
- Hits            788      769      -19     
+ Misses         2177     2173       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit beccc8f into main May 2, 2024
7 checks passed
@cleptric cleptric deleted the only-spans branch May 2, 2024 18:20
Copy link

sentry-io bot commented May 3, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Cannot access protected property Sentry\Tracing\Span::$spanId /src/Http/Client.php in App\Http\Client::_sendR... View Issue

Did you find this useful? React with a 👍 or 👎

cleptric added a commit that referenced this pull request May 6, 2024
cleptric added a commit that referenced this pull request May 8, 2024
@cleptric cleptric restored the only-spans branch September 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant