fix(potal|backend): Add missing response status to HTTP client spans

getsentry · Jul 10, 2024 · d762635 · d762635
1 parent 9e2e24b
commit d762635
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/potal/internal/potalhttp/client.go b/potal/internal/potalhttp/client.go
@@ -52,6 +52,10 @@ func SendRequest(ctx context.Context, e event.PotalEvent) error {
 	}
 	defer res.Body.Close()
 
+	span.Data = map[string]interface{}{
+		"http.response.status_code": res.StatusCode,
+	}
+
 	switch res.StatusCode {
 	case http.StatusOK:
 		span.Status = sentry.SpanStatusOK

diff --git a/src/Http/Client.php b/src/Http/Client.php
@@ -41,8 +41,12 @@ protected function _sendRequest(RequestInterface $request, array $options): Resp
         $response = parent::_sendRequest($request, $options);
 
         if ($span !== null) {
-            $span->setHttpStatus($response->getStatusCode());
-            $span->finish();
+            $span
+                ->setHttpStatus($response->getStatusCode())
+                ->setData([
+                    'http.response.status_code' => $response->getStatusCode()
+                ])
+                ->finish();
         }
 
         return $response;