Fix bug when scope is repository #17
Conversation
|
@billyvg Hello, Please check me 🙏 |
src/main.ts
Outdated
| return {error: `GitHub Apps can't accessible repository (${repository})`}; | ||
| } | ||
|
|
||
| return {error: ''}; |
There was a problem hiding this comment.
Instead of returning an object, let's throw an error. This will simplify the error handling logic where we call this function. The exception will get caught by https://github.com/getsentry/action-github-app-token/pull/17/files#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR65
There was a problem hiding this comment.
i fixed in f318804 !
|
@billyvg Can you configure |
|
@whywaita Hmm it should be configured -- does this work for you locally? I'm not sure, but it sounds like https://github.com/getsentry/action-github-app-token/pull/17/files#diff-4fab5baaca5c14d2de62d8d2fceef376ddddcc8e9509d86cfa5643f51b89ce3dR70-R73 needs |
yes, I use the fork branch (whywaita@fix/repository-selected) to register a self-hosted runner.
I will try to fix it. |
|
@billyvg I saw Actions page, I can't found
|
|
I found a mistake, It needs to check pagination. |
|
@billyvg Hi, Can you re-run a CI in this branch? |
#11 added
scope, but this change has a bug when setting the repository. 🙇GET /app/installationsresponse login_name, but it is organization name or username (not repository name).So this change fixes bugs when setting repository to scope.