Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Secret Scan Log Forwarding #146

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Update Secret Scan Log Forwarding #146

merged 9 commits into from
Oct 30, 2024

Conversation

Jeffreyhung
Copy link
Member

@Jeffreyhung Jeffreyhung commented Oct 30, 2024 •
edited
Loading

  • Send all scanning events to panther
  • remove redundant double-quote
  • bump trufflehog to 3.82.13
  • Add missing double-quote for createAt

geoffg-sentry
geoffg-sentry approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@geoffg-sentry geoffg-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might end up in an awful lot of secret scan results being forwarded to Panther, since every non-failure result is also delivered. Gonna give it a try and flip if off if it ends up being too voluminous/expensive for ingest.

@geoffg-sentry geoffg-sentry merged commit db5a9a8 into main Oct 30, 2024
2 checks passed
@geoffg-sentry geoffg-sentry deleted the forward-secret-scanning-alert-to-panther branch October 30, 2024 17:05
geoffg-sentry added a commit that referenced this pull request Oct 30, 2024
@geoffg-sentry
Add quotes to status value
cc22a51 
Whoops, I missed this in my review of #146. Value of status needs to be quoted.

Currently the log looks like
{"event":"github_secret_scanning", "status":success, "createdAt":"2024-10-30T17:20:07Z", "repo":"getsentry/gocd-jsonnet","pull_request":"https://github.com/getsentry/gocd-jsonnet/pull/83","actor":"IanWoodard"}
@geoffg-sentry geoffg-sentry mentioned this pull request Oct 30, 2024
Merged
geoffg-sentry added a commit that referenced this pull request Oct 30, 2024
@geoffg-sentry
Add quotes to status value (#147)
f0fdb2d 
Whoops, I missed this in my review of #146. Value of status needs to be quoted.

Currently the log looks like
{"event":"github_secret_scanning", "status":success, "createdAt":"2024-10-30T17:20:07Z", "repo":"getsentry/gocd-jsonnet","pull_request":"https://github.com/getsentry/gocd-jsonnet/pull/83","actor":"IanWoodard"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffg-sentry geoffg-sentry geoffg-sentry approved these changes

@mdtro mdtro Awaiting requested review from mdtro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeffreyhung @geoffg-sentry