Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record/history: add support for bash shells #67

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

joshi4
Copy link
Contributor

@joshi4 joshi4 commented Mar 12, 2024

  • cmd/history: fix typo for psuedo terminal
  • shell/bash: do not rely on SAVVY_LOGIN_SHELL for bash
  • shell/bash: tail bash history
  • shell/bash: spawn bash shell to expand the history commands

joshi4 added 4 commits March 11, 2024 15:52
we use shopt -q login_shell to determine if the shell is in login mode
or not.

This should significantly improve first run experience for bash shells
@joshi4 joshi4 force-pushed the sj/record-bash-history branch from 51bff62 to a6dfd4c Compare March 12, 2024 01:19
@joshi4 joshi4 merged commit 7e68408 into main Mar 12, 2024
1 check passed
@joshi4 joshi4 deleted the sj/record-bash-history branch March 12, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant