-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic database upgrades #7166
base: master
Are you sure you want to change the base?
Conversation
dd5905d
to
4bc7fdb
Compare
@@ -42,6 +42,10 @@ dev_worker() { | |||
} | |||
|
|||
server() { | |||
echo "Upgrading database..." | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably doesn't need the blank line between the echo and the manage.py command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is one blank line between echo
and exec
in scheduler()
, dev_scheduler()
, worker()
, dev_worker()
. thought I should just keep up with the neighbors to be consistent 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my bad. 🤦
Yeah, copying the existing style is the right approach. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timing wise, @arikfr is working on a patch to fix the generation of query hashes, and I think might also be adjusting one of the migrations so it takes the auto limit into account as well.
That should turn up in the next few days hopefully, and I'd personally like for us to get that in before this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What type of PR is this?
Description
Automatically upgrade the database upon services start-up. So that we don't need to do it manually using cli tools on the server. #7167 has to go in first because upgrading db takes time. The rest of the program has to wait for it to finish.
I started the discussion #7005 on automated db migration mechanisms.
Further discussing: #7161 (comment)
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)