Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an environment variable to switch on/off sort columns #7119

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zachliu
Copy link
Contributor

@zachliu zachliu commented Aug 12, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

There are many cases where sorting the columns alphabetically is considered an unwanted manipulation of the raw data. For example, certain types of marketing raw data group the columns by category such as campaign attributes, different types of conversions, look-back windows etc.

I added a new environment variable REDASH_SCHEMAS_SORT_COLUMNS (set to True by default) to switch the column sorting on/off.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant