Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: requirements sorting #6388

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

denisov-vlad
Copy link
Member

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Added pre-commit hook for sorting requirements files.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #6388 (a32a304) into master (7eae598) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6388   +/-   ##
=======================================
  Coverage   60.73%   60.73%           
=======================================
  Files         154      154           
  Lines       12626    12626           
  Branches     1716     1716           
=======================================
  Hits         7669     7669           
  Misses       4732     4732           
  Partials      225      225           

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Looks good to me. 😄

@justinclift justinclift merged commit 1af49e9 into getredash:master Aug 23, 2023
12 checks passed
@justinclift
Copy link
Member

Thanks for this @denisov-vlad, I've been wondering how to fix this "properly" for a while. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants