Fix: Cannot refresh if a query name contain control characters.

[iwakiriK]

What type of PR is this? (check all applicable)

• Bug Fix

Description

If a query name contains control characters, it cannot be refreshed.

We find out that the problem occurs in the response header.
https://github.com/getredash/redash/blob/v10.0.0-beta/redash/handlers/query_results.py#L422

This PR will fix this problem.

How to Reproduce

• Create a query
• Copy a control character and paste them in the query name
  • http://www.unicode-symbol.com/u/0010.html
• Reload

Related Tickets & Documents

https://www.regular-expressions.info/unicode.html
https://www.compart.com/en/unicode/category
https://pypi.org/project/regex/
https://stackoverflow.com/questions/1832893/python-regex-matching-unicode-properties/4316097#4316097

[guidopetri]

@iwakiriK , thanks for the PR! Same here, we've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

[justinclift]

Just attempted to fix the merge conflict using the web interface. It'll probably need some formatting clean up though.

[codecov]

Codecov Report

Merging #5602 (5410b97) into master (1af49e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5602   +/-   ##
=======================================
  Coverage   60.73%   60.74%           
=======================================
  Files         154      154           
  Lines       12626    12628    +2     
  Branches     1716     1716           
=======================================
+ Hits         7669     7671    +2     
  Misses       4732     4732           
  Partials      225      225           

Files Changed	Coverage Δ
redash/handlers/query_results.py	81.57% <100.00%> (+0.19%)	⬆️

[justinclift]

@konnectr Any interest in reviewing this? It's passing our CI tests, and looks fairly simple. 😄

[justinclift]

Thanks heaps @konnectr. 😄