[Data Sources] Add: MemSQL query runner #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
requested changes
May 17, 2017
redash/query_runner/memsql_ds.py
Outdated
| } | ||
|
|
||
| }, | ||
| "required": ["host", "port"] |
There was a problem hiding this comment.
Please add a secret field too (look at other data sources for example).
redash/query_runner/memsql_ds.py
Outdated
|
|
||
| schema[table_name] = {'name': table_name, 'columns': columns} | ||
| except Exception, e: | ||
| raise sys.exc_info()[1], None, sys.exc_info()[2] |
There was a problem hiding this comment.
the Exception handling?
redash/query_runner/memsql_ds.py
Outdated
| columns.append({ | ||
| 'name': column, | ||
| 'friendly_name': column, | ||
| 'type': None |
There was a problem hiding this comment.
It's better to use TYPE_STRING instead of None.
requirements.txt
Outdated
| @@ -42,4 +42,6 @@ xlsxwriter==0.9.3 | |||
| pystache==0.5.4 | |||
| parsedatetime==2.1 | |||
| cryptography==1.4 | |||
| oauthlib==2.0.0 | |||
| WTForms==2.1 | |||
arikfr
approved these changes
May 18, 2017
|
Thanks. :) |
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
[Data Sources] Add: MemSQL query runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/memsql/memsql-python/
meanwhile the column types aren't available.
pending on memsql/memsql-python#8