Add test of relevance on calculates #704
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
reviewed
Jan 9, 2023
| @@ -530,6 +530,33 @@ public void non_relevant_node_values_are_always_null_regardless_of_their_actual_ | |||
| assertThat(scenario.answerOf("/data/some-field"), is(intAnswer(42))); | |||
| } | |||
|
|
|||
| // Users use relevance on calculates to ensure that calculations are only run when the values | |||
There was a problem hiding this comment.
Is it important to make sure that the calculation isn't executed or just that the calculation isn't "answered"? I'm guessing it's the latter (as that's what this test is about), but the comment suggests it might the former.
There was a problem hiding this comment.
Great and deep question. Now I'm no longer 100% sure of the intent. This led me to some strange docs: getodk/docs#1547 I will come back to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pattern that we broke in Enketo a while ago. I want to make sure it's explicitly tested here because it is a bit surprising.