Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/nginx: remove letsencrypt-specific tests #748

Merged
merged 1 commit into from
Oct 11, 2024
Merged

test/nginx: remove letsencrypt-specific tests #748

merged 1 commit into from
Oct 11, 2024

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 9, 2024

  • /.well-known/acme-challenge path isn't relevant to these tests, as they do not use letsencrypt SSL certs
  • in the test scenario, specific handling for /.well-known/acme-challenge is removed from redirector.conf in files/nginx/setup-odk.sh
  • the tests don't make sense, as they're checking for 404s

test/nginx: remove checks for well-known/acme-challenge
8cf6c68 
* this path isn't relevant to these tests, as they do not use letsencrypt SSL certs
* the tests don't make sense, as they're checking for 404s
* in the test scenario, specific handling for this path is removed from redirector.conf in files/nginx/setup-odk.sh
@alxndrsn alxndrsn requested a review from lognaturel October 9, 2024 08:11
@alxndrsn alxndrsn merged commit 29c42ff into getodk:next Oct 11, 2024
2 checks passed
@alxndrsn alxndrsn deleted the remove-nginx-acme-test branch October 11, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxndrsn @lognaturel