Skip to content

Commit

Permalink
Merge pull request #404 from getodk/attachments-param
Browse files Browse the repository at this point in the history
Rename ?media query parameter to ?attachments
  • Loading branch information
matthew-white authored Dec 21, 2020
2 parents 5faf2e4 + 8dc5390 commit 5d056e5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/components/submission/download-dropdown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ except according to the terms contained in the LICENSE file.
</a>
</li>
<li>
<a :href="href('.csv.zip', { media: false })" :target="target">
<a :href="href('.csv.zip', { attachments: false })" :target="target">
{{ $t('action.download.withoutMedia') }}
</a>
</li>
Expand Down
6 changes: 3 additions & 3 deletions test/components/submission/download-dropdown.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe('SubmissionDownloadDropdown', () => {
testData.extendedForms.createPast(1);
mountComponent().find('a').map(a => a.getAttribute('href')).should.eql([
'/v1/projects/1/forms/f/submissions.csv.zip',
'/v1/projects/1/forms/f/submissions.csv.zip?media=false',
'/v1/projects/1/forms/f/submissions.csv.zip?attachments=false',
'/v1/projects/1/forms/f/submissions.csv'
]);
});
Expand Down Expand Up @@ -128,7 +128,7 @@ describe('SubmissionDownloadDropdown', () => {
trigger.click(dropdown.find('a')[1]);
$emit.getCall(0).args.should.eql([
'decrypt',
'/v1/projects/1/forms/f/submissions.csv.zip?media=false'
'/v1/projects/1/forms/f/submissions.csv.zip?attachments=false'
]);
});

Expand Down Expand Up @@ -189,7 +189,7 @@ describe('SubmissionDownloadDropdown', () => {
});
dropdown.find('a').map(a => a.getAttribute('href')).should.eql([
'/v1/projects/1/forms/f/submissions.csv.zip?%24filter=__system%2FsubmitterId+eq+1',
'/v1/projects/1/forms/f/submissions.csv.zip?media=false&%24filter=__system%2FsubmitterId+eq+1',
'/v1/projects/1/forms/f/submissions.csv.zip?attachments=false&%24filter=__system%2FsubmitterId+eq+1',
'/v1/projects/1/forms/f/submissions.csv?%24filter=__system%2FsubmitterId+eq+1'
]);
});
Expand Down

0 comments on commit 5d056e5

Please sign in to comment.