Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update botocore version specifiers #8249

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Update botocore version specifiers #8249

merged 2 commits into from
Oct 23, 2024

Conversation

bblommers
Copy link
Collaborator

Reverts #8248
Should work again now that botocore 1.35.46 is out (see boto/botocore#3284)

@bblommers bblommers added this to the 5.0.18 milestone Oct 22, 2024
@bblommers
Copy link
Collaborator Author

FYI @bpandola - it looks like this is still failing

@bpandola
Copy link
Collaborator

@bblommers Yeah, there are two issues (at least). The botocore change contained a regression, but the new code they added breaks our BotocoreStubber. I have an idea for a quick fix... not sure if it will work, though. I'll provide a PR and some more detail in a bit.

@bpandola
Copy link
Collaborator

@bblommers This is still an issue with botocore at the moment. I've updated my original issue in their repo with additional information.

@bblommers
Copy link
Collaborator Author

Thanks for following up on this @bpandola!

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (036c4a1) to head (68532cf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8249   +/-   ##
=======================================
  Coverage   94.55%   94.55%           
=======================================
  Files        1158     1158           
  Lines      100287   100287           
=======================================
  Hits        94828    94828           
  Misses       5459     5459           
Flag Coverage Δ
servertests 28.90% <ø> (ø)
unittests 94.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bpandola bpandola changed the title Remove botocore pin Update botocore version specifiers Oct 23, 2024
@bpandola bpandola merged commit 6e705a8 into master Oct 23, 2024
104 checks passed
@bpandola bpandola deleted the bblommers-patch-2 branch October 23, 2024 22:19
@bblommers bblommers modified the milestones: 5.0.18, 5.0.19 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants