Fixed failed array test

getml · Nov 9, 2024 · bd40b7a · bd40b7a
1 parent ab72519
commit bd40b7a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/include/rfl/ubjson/Reader.hpp b/include/rfl/ubjson/Reader.hpp
@@ -87,13 +87,14 @@ class Reader {
     }
   }
 
-  rfl::Result<InputArrayType> to_array(InputVarType _var) const noexcept;
+  rfl::Result<InputArrayType> to_array(const InputVarType& _var) const noexcept;
 
-  rfl::Result<InputObjectType> to_object(InputVarType _var) const noexcept;
+  rfl::Result<InputObjectType> to_object(
+      const InputVarType& _var) const noexcept;
 
   template <class ArrayReader>
-  std::optional<Error> read_array(ArrayReader _array_reader,
-                                  InputArrayType _arr) const noexcept {
+  std::optional<Error> read_array(const ArrayReader& _array_reader,
+                                  const InputArrayType& _arr) const noexcept {
     for (auto& val : _arr.val_->array_range()) {
       const auto err = _array_reader.read(InputVarType{&val});
       if (err) {
@@ -105,7 +106,7 @@ class Reader {
 
   template <class ObjectReader>
   std::optional<Error> read_object(const ObjectReader& _object_reader,
-                                   InputObjectType _obj) const noexcept {
+                                   const InputObjectType& _obj) const noexcept {
     for (auto& kv : _obj.val_->object_range()) {
       _object_reader.read(kv.key(), InputVarType{&kv.value()});
     }

diff --git a/src/rfl/ubjson/Reader.cpp b/src/rfl/ubjson/Reader.cpp
@@ -25,15 +25,15 @@ bool Reader::is_empty(const InputVarType& _var) const noexcept {
 }
 
 rfl::Result<Reader::InputArrayType> Reader::to_array(
-    InputVarType _var) const noexcept {
+    const InputVarType& _var) const noexcept {
   if (!_var.val_->is_array()) {
     return Error("Could not cast to an array.");
   }
   return InputArrayType{_var.val_};
 }
 
 rfl::Result<Reader::InputObjectType> Reader::to_object(
-    InputVarType _var) const noexcept {
+    const InputVarType& _var) const noexcept {
   if (!_var.val_->is_object()) {
     return Error("Could not cast to an object.");
   }