Initialize all domain fronting code one time on startup #1452
+538
−3,008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current startup sequence suffers from some byzantine code for initializing the stored global config (either embedded or saved), which is then required for initializing all fronting code that is necessary for config fetches, particularly for first time users. This is exacerbated by the getlantern/fronted code, which is very rapidly initialized twice in many cases -- once with using the global config on disk, and once using the fetched global config. In that process, any previously verified and working fronts are discarded, but also any code unlucky enough to be called prior to the new global config being fetched keeps mindlessly chugging through outdated fronts.
This attempts to address all that by initializing the fronting code right away in a straightforward manner and then updating the fronting code with new fronts from the network vs replacing it wholesale.