Update domain fronting to use new Lantern Cloud domain #1416
Conversation
This domain will accept fronted requests as well as direct requests.
| if strings.HasPrefix(r.URL.Path, "/pro/") { | ||
| r.URL.Path = r.URL.Path[4:] | ||
| } |
There was a problem hiding this comment.
Drive-by / fix: adding a guard here to avoid indiscriminately modifying path prefixes.
| @@ -22,12 +22,12 @@ var ( | |||
| maxLogSize = 10247680 | |||
|
|
|||
| client = &http.Client{ | |||
| Transport: proxied.Fronted(0), | |||
| Transport: proxied.ChainedThenFronted(), | |||
There was a problem hiding this comment.
This will allow clients to try sending issue reports through their proxies.
|
I'll look at the failed tests later today. |
|
There is only a single test failing now: I'm going to go ahead and merge. Thanks for the reviews everyone! |
Co-authored-by: Wendel Hime <[email protected]>
Forgot to comment about this, but I'm actually holding off on merging until I can get the lantern-client changes done and thoroughly tested. These changes affect much of the client's ability to communicate with the back-end. I want to be sure to catch any bugs before merging this into |
This domain will accept fronted requests as well as direct requests.
This is part 1 of the work outlined in https://github.com/getlantern/engineering/issues/1429#issuecomment-2350136738. A follow-up PR will address the lantern-client changes.