-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Traefik Reverse Proxy with Let's Encrypt and Centralized Environment Configuration into docker-compose.yaml #414
base: main
Are you sure you want to change the base?
Conversation
6766c5b
to
34d4d01
Compare
…environment variable
…dling for services; remove container_name from db, redis, and api-worker
…d specific anchors
…e service configurations
…main templating - Enable Let's Encrypt support with ACME resolver 'myresolver' - Update Traefik rules to support templated DOMAIN variable - Remove unnecessary port mappings from API and frontend services - Secure Traefik dashboard and disable 'exposedbydefault' for improved security
…er a single domain - Update Traefik rules to use a single domain with path prefixes - Add middleware to strip '/api' prefix for the API service - Set router priorities to resolve routing conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
Since it's a breaking change, we have to discuss the release process and the way to communicate about it.
can we rename the |
Done |
can we rename the |
….new.yaml to let user time to migrate
…e docker-compose.old.yml
… moving back docker-compose.yml
Description
This pull request introduces several key updates and improvements to the repository, including:
Addition of Traefik Configuration:
443
, with automated redirection from HTTP.traefik
with customizable entry points for HTTP and HTTPS and new certificate resolvers for better security.Improved
docker-compose.yml
Setup:x-common-environment
,x-api-environment
, andx-front-environment
), improving readability and maintainability./api
for API calls.Enhanced Routing and Domain Management:
/api
routes to the API, while the root path routes to the frontend..env
file template for customizable environment variables, facilitating deployments in different environments.docker-compose.yml
and.env
files to support domain templating and the new routing structure are included.Additional Documentation and Configurations:
docker-compose-old.yml
file was introduced for reference, documenting previous configurations and allowing easier migration to the new setup.Changes
.env
File: Added for centralized configuration management, supporting easier setup across various environments.docker-compose-old.yml
): Provides a backup of the previous configuration for reference and testing.Motivation and Context
This PR is intended to simplify and secure the deployment of the Lago services, leveraging Traefik for reverse proxy management and Let's Encrypt for SSL certificate handling. It also aims to streamline the environment configuration process, allowing easier setup and customizability for different deployment scenarios.
Types of changes
Breaking change with the current docker-compose, moving it into
docker-compose-old.yaml
for the moment