-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update #43
Open
lexisvar
wants to merge
79
commits into
getherbert:use-illuminate-request
Choose a base branch
from
lexisvar:dev
base: use-illuminate-request
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move to illuminate's request instead of our own http implementation
…helpers and changed Panel@url to not depend on WP's admin_menu state
support position param for menu pages
…p to 0.9.10 + made the enqueue panel matcher much better
Plugin activation results on some setups in following error: Warning: is_dir(): open_basedir restriction in effect. File(/) is not within the allowed path(s): (/xxx/:/tmp) in /xxx/vendor/twig/twig/lib/Twig/Loader/Filesystem.php on line 93 This can be easily fixed applying this simple change.
Adds support for WordPress' script localization feature.
TO Set Default Collate to Avoid PDO Exceptions
To Set COLLATE as Wordpress Default Collate
I don't generate any routes with herbert. I noticed that my nginx error log was getting flooded with errors about foreach not having a valid argument. So I added a check to make sure that there is in fact an array of routes to add before trying to iterate it! No more log spam.
Router argument issue
Adds support for script localization
Fix: open_basedir restriction
Throw fatal error when the parameter $callable in $shortcode->add() i…
Add capabilities as argument for panels
* Fixed filtering enqueue by post type Method was always returning true so filtering wasn't working * Removed ternary operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update