fix: update pattern format #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seren5240
approved these changes
Apr 13, 2024
| tags: [java] | ||
| --- | ||
|
|
||
| # "BigDecimal(double)" should not be used |
There was a problem hiding this comment.
I feel like using h1 as the title is more self-descriptive for patterns as opposed to relying on the title frontmatter.
In general, I think a good litmus test here is for the frontmatter to be completely optional by default, and I think this change moves in the opposite direction.
Thoughts?
There was a problem hiding this comment.
Both are allowed - frontmatter is optional, and you can just use h1. In this case we had both so I removed one.
Many patterns still use an H1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve standardization of patterns to prepare for getgrit/gritql#221
Requires getgrit/gritql#221