Merge branch 'main' into fix/typos

.grit/patterns/css/aspect_ratio.md

@@ -2,8 +2,6 @@
 title: Aspect ratio
 ---
 
-# {{ page.title }}
-
 ```grit
 language css
 

.grit/patterns/go/cloudflare_go_v2.md

@@ -11,6 +11,13 @@ Future migrations will be more seamless as we will be automatically generating t
 {% /note %}
 
 
+This migration can be applied automatically using the [Grit CLI](https://docs.grit.io/cli/quickstart):
+
+```
+grit apply cloudflare_go_v2
+```
+
+
 ```grit
 language go
 
@@ -651,12 +658,6 @@ file($body) where {
 }
 ```
 
-This migration can be applied automatically using the [Grit CLI](https://docs.grit.io/cli/quickstart):
-
-```
-grit apply cloudflare_go_v2
-```
-
 ## Client construction with API key and email
 
 Old:

.grit/patterns/java/no_big_decimal_double.md

@@ -1,10 +1,8 @@
 ---
-title: "BigDecimal(double)" should not be used
+title: "`BigDecimal(double)` should not be used"
 tags: [java]
 ---
 
-# "BigDecimal(double)" should not be used
-
 Because of floating point imprecision, the `BigDecimal(double)` constructor can be somewhat unpredictable. It is better to use `BigDecimal.valueOf(double)`.
 
 

.grit/patterns/js/intelligent_useEffect_to_useLayoutEffect.md

@@ -1,5 +1,5 @@
 ---
-title: [React2Hooks] Intelligent useEffect vs useLayoutEffect
+title: "[React2Hooks] Intelligent useEffect vs useLayoutEffect"
 tags: [fix]
 ---
 

.grit/patterns/js/no_return_assign.md

@@ -3,10 +3,9 @@ title: Hoist assignment out of `return` statement
 tags: [good, se]
 ---
 
-# {{ page.title }}
-
-This rule hoists the assignments out of `return`. Does not apply when assignment is wrapped in parentheses.
+This rule hoists the assignments out of `return`. Because an assignment, `=` is easy to confuse with a comparison, `==`, The best practice is not to use any assignments in return statements.
 
+This does not apply when assignment is wrapped in parentheses.
 
 ```grit
 engine marzano(0.1)
@@ -21,10 +20,6 @@ language js
 } => `$assignment;\n  return $left;`
 ```
 
-```
-An assignment, `=`, is easy to confuse with a comparison, `==`. The best practice is not to use any assignments in return statements.
-```
-
 ## Hoist `=` from `return` statement
 
 ```javascript

.grit/patterns/js/no_unsafe_negation.md

@@ -3,8 +3,6 @@ title: Rewrite `!key in col` ⇒ `!(key in col)`
 tags: [fix]
 ---
 
-# {{ page.title }}
-
 Negates `key` instead of the entire expression, which is likely a bug.
 
 The intent is usually to negate the entire relation expression.

.grit/patterns/js/prefer_early_return.md

@@ -3,8 +3,6 @@ title: PreferEarlyReturn
 tags: [lint, style]
 ---
 
-# {{ page.title }}
-
 Prefer to use early returns to keep functions flat.
 
 

.grit/patterns/python/_test_add_multiple_bare_imports.md

@@ -21,14 +21,15 @@ language python
 
 
 ```python
+# This is an empty block
 ```
 
 ```python
 import math
 import re
 import json
 
-
+# This is an empty block
 ```
 
 ## Add missing imports

.grit/patterns/python/_test_add_one_bare_import.md

@@ -17,12 +17,13 @@ language python
 
 
 ```python
+# Add one
 ```
 
 ```python
 import math
 
-
+# Add one
 ```
 
 ## Do not add duplicate bare import

.grit/patterns/python/_test_ensure_import_from.md

@@ -17,12 +17,13 @@ language python
 
 
 ```python
+# Empty block
 ```
 
 ```python
 from math import prod
 
-
+# Empty block
 ```
 
 ## Add one more name to source

.grit/patterns/solidity/EtherTransfer.md

@@ -2,8 +2,6 @@
 title: Ether Transfer
 ---
 
-# {{ page.title }}
-
 ```grit
 language sol
 

.grit/patterns/solidity/NestedLoop.md

@@ -3,8 +3,6 @@ title: Nested Loop
 tags: [reentrancy, vulnerability]
 ---
 
-# {{ page.title }}
-
 Inspect nested loops.
 
 

.grit/patterns/solidity/NoMulDivRoundUp.md

@@ -2,8 +2,6 @@
 title: NoMulDiv
 ---
 
-# {{ page.title }}
-
 Say we do not want `mulDivRoundUp`.
 
 ```grit

.grit/patterns/solidity/UpgradableProxyPattern.md

@@ -3,8 +3,6 @@ title: Upgradable Proxy Pattern
 tags: [reentrancy, vulnerability]
 ---
 
-# {{ page.title }}
-
 Looking for variations of the upgradable proxy pattern.
 
 

.grit/patterns/sql/add_pg_unit_test.md

@@ -45,9 +45,9 @@ CREATE PROCEDURE remove_emp(employee_id int) AS
    tot_emps := tot_emps - 1;
    END;
 
+
 -- Check that 'remove_emp' has been translated into valid plpgsql
 SELECT has_function('remove_emp');
 SELECT is_procedure('remove_emp');
 SELECT function_lang_is('remove_emp', 'pgplsql' );
-
 ```

.grit/patterns/sql/oracle_quote_procedure.md

@@ -1,5 +1,5 @@
 ---
-title: Oracle to PG: Dollar quote stored procedure body
+title: "Oracle to PG: Dollar quote stored procedure body"
 ---
 
 In Postgres, function and procedure bodies need to be wrapped in $$dollar quotes$$.
@@ -40,4 +40,4 @@ CREATE PROCEDURE remove_emp (employee_id int) AS
    tot_emps := tot_emps - 1;
    END;
 $$ LANGUAGE plpgsql;
-```
+```

.grit/patterns/sql/oracle_to_pg.md

@@ -69,9 +69,9 @@ CREATE PROCEDURE remove_emp(employee_id NUMERIC) AS
    END;
 $$ LANGUAGE plpgsql;
 
+
 -- Check that 'remove_emp' has been translated into valid plpgsql
 SELECT has_function('remove_emp');
 SELECT is_procedure('remove_emp');
 SELECT function_lang_is('remove_emp', 'pgplsql' );
-
 ```

.grit/patterns/yaml/concourse_v7.md

@@ -136,76 +136,87 @@ jobs:
               code: one-js
           output_mapping:
               code: a-js
+
         - task: create-file-2
           params:
               FUNCTION: file2-js
           input_mapping:
               code: one-js
           output_mapping:
               code: a-js
+
         - task: create-file-3
           params:
               FUNCTION: file3-js
           input_mapping:
               code: one-js
           output_mapping:
               code: a-js
+
         - task: create-file-4
           params:
               FUNCTION: file1-js
           input_mapping:
               code: two-js
           output_mapping:
               code: a-js
+
         - task: create-file-5
           params:
               FUNCTION: file2-js
           input_mapping:
               code: two-js
           output_mapping:
               code: a-js
+
         - task: create-file-6
           params:
               FUNCTION: file3-js
           input_mapping:
               code: two-js
           output_mapping:
               code: a-js
+
         - task: create-file-7
           params:
               FUNCTION: file1-js
           input_mapping:
               code: one-js
           output_mapping:
               code: b-js
+
         - task: create-file-8
           params:
               FUNCTION: file2-js
           input_mapping:
               code: one-js
           output_mapping:
               code: b-js
+
         - task: create-file-9
           params:
               FUNCTION: file3-js
           input_mapping:
               code: one-js
           output_mapping:
               code: b-js
+
         - task: create-file-10
           params:
               FUNCTION: file1-js
           input_mapping:
               code: two-js
           output_mapping:
               code: b-js
+
         - task: create-file-11
           params:
               FUNCTION: file2-js
           input_mapping:
               code: two-js
           output_mapping:
               code: b-js
+
         - task: create-file-12
           params:
               FUNCTION: file3-js

old_patterns/NonTrivialMath.md

@@ -2,8 +2,6 @@
 title: Non-trivial math
 ---
 
-# {{ page.title }}
-
 ```grit
 or {
   // ds-math

old_patterns/ReentrancyBeforeAndAfter.md

@@ -2,8 +2,6 @@
 title: Reentrancy, assignments both before and after
 ---
 
-# {{ page.title }}
-
 A transfer with member assignments both before and after the transfer.
 
 See case 2 here: https://github.com/runtimeverification/amp/issues/39#issuecomment-1137314683

old_patterns/ReentrancyLowRisk.md

@@ -2,8 +2,6 @@
 title: Reentrancy, not last line
 ---
 
-# {{ page.title }}
-
 Member assignemnt just before the transfer, but transfer not on the last line
 
 See case 3 here: https://github.com/runtimeverification/amp/issues/39#issuecomment-1137314683

old_patterns/ReentrancyNoBefore.md

@@ -2,8 +2,6 @@
 title: Reentrancy, no assignment before
 ---
 
-# {{ page.title }}
-
 No field assignment before a transfer.
 
 See case 1 here: https://github.com/runtimeverification/amp/issues/39#issuecomment-1137314683

wip/StyledJSXToCSSModules.md

@@ -2,8 +2,6 @@
 title: Convert Styled JSX to CSS Modules
 ---
 
-# {{ page.title }}
-
 Extract all Styled JSX from a particular file and move it to CSS Module files.
 
 - If there are multiple components in a given file, we create separate CSS Module file for each one.