Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate Select component to functional component using useState hook #1176

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

npham49
Copy link
Contributor

@npham49 npham49 commented Jul 11, 2024

Issue: #730

Description of changes:

  • Refactored form/Select component to funcitonal component
  • Kept all the original functionality and jsx code

Question:

  • When working on this, my terminal threw an error: invalid go version '1.22.0': must match format 1.23 which required me to change the go.mod to 1.22, let me know if I need to change it back and how I can fix this error!

…ased this off of the form/Input component), changed the version in go.mod to 1.22
@mattwoberts
Copy link
Contributor

@npham49 Awesome thanks.

There is an issue with the go version though. It fails to build on my (Apple Silicon) mac:

go build -ldflags '-s -w -X github.com/getfider/fider/app/pkg/env.commithash=' -o fider .
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
make: *** [build-server] Error 1

Looking at golang/go#62278 (comment) and it seems to be that a specific version is needed for a toolchain to be used, so I need to change to 1.22.0 in order for it to work on my machine.

@npham49
Copy link
Contributor Author

npham49 commented Jul 11, 2024

@npham49 Awesome thanks.

There is an issue with the go version though. It fails to build on my (Apple Silicon) mac:

go build -ldflags '-s -w -X github.com/getfider/fider/app/pkg/env.commithash=' -o fider .
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
make: *** [build-server] Error 1

Looking at golang/go#62278 (comment) and it seems to be that a specific version is needed for a toolchain to be used, so I need to change to 1.22.0 in order for it to work on my machine.

Thanks for having a look at this so fast! I think this might be a problem with the go setup on my end then, I'll go ahead and fix my setup, and then push another commit changing it back to 1.22.0.

@mattwoberts
Copy link
Contributor

Cool. I'm just curious - what motivated you to pick this up? Strange question i know but I'm still finding my feet with it myself so the more i ask the better 👍

@npham49
Copy link
Contributor Author

npham49 commented Jul 11, 2024

For this specific issue? I was just going through the "help wanted" items, and working on the ones that I can do. I'm pretty new to Go (this project is literally my first-time using Go), but I've been working with React professionally for a couple years now, so these React tickets are more straight-forward for me.

Also, congratulations on being the new owners! Fider was used in my previous company, and we loved how easy and intuitive it was for end user to log feedback.

@mattwoberts
Copy link
Contributor

Ah I see, thanks :) I was curious why you picked fider to contribute to - so that makes sense that you knew of it from using it.

Thanks for the kind words - we're hoping to add some nice features to fider and boost the customer count over at fider.io - all of which should benefit the self hosters :)

@mattwoberts mattwoberts merged commit a108bed into getfider:main Jul 11, 2024
8 checks passed
@npham49
Copy link
Contributor Author

npham49 commented Jul 11, 2024

@mattwoberts it's an awesome piece of software! Let me know if you need help with any of the new features/bug fixes (tag me in any issues or whichever project board you're using), I'm more than happy to contribute to make fider even better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants