Skip to content

Commit

Permalink
Merge pull request #1232 from getfider/playwright-update
Browse files Browse the repository at this point in the history
Playwright update to fix build
  • Loading branch information
mattwoberts authored Dec 18, 2024
2 parents c4f375e + 86f46d5 commit 994155b
Show file tree
Hide file tree
Showing 6 changed files with 82 additions and 53 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,7 @@ jobs:
-v "$PWD"/etc:/app/etc \
fider-image
- run: npm ci
- run: |
sudo apt-get update
sudo apt-get install -y libasound2t64
npx playwright install-deps $BROWSER
- run: npx playwright install --with-deps $BROWSER
env:
BROWSER: ${{ matrix.browser }}
- run: make test-e2e-ui
Expand Down Expand Up @@ -212,7 +209,7 @@ jobs:
-v "$PWD"/etc:/app/etc \
fider-image
- run: npm ci
- run: npx playwright install-deps chromium
- run: npx playwright install --with-deps chromium
env:
BROWSER: chromium
- run: make test-e2e-server
Expand Down
2 changes: 1 addition & 1 deletion e2e/setup.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Before, BeforeAll, AfterAll, After } from "@cucumber/cucumber"
import debug from "debug"
import * as playwright from "playwright"
import * as playwright from "@playwright/test"
import { getLatestLinkSentTo } from "./step_definitions/fns"
import { FiderWorld } from "./world"

Expand Down
2 changes: 1 addition & 1 deletion e2e/step_definitions/fns.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Page } from "playwright"
import { Page } from "@playwright/test"

export function delay(ms: number) {
return new Promise((resolve) => setTimeout(resolve, ms))
Expand Down
2 changes: 1 addition & 1 deletion e2e/world.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { World as CucumberWorld } from "@cucumber/cucumber"
import { Page } from "playwright"
import { Page } from "@playwright/test"

export interface FiderWorld extends CucumberWorld {
tenantName: string
Expand Down
120 changes: 76 additions & 44 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"@lingui/cli": "3.13.3",
"@lingui/loader": "3.13.3",
"@lingui/macro": "3.13.3",
"@playwright/test": "1.48",
"@testing-library/jest-dom": "5.16.4",
"@testing-library/react": "12.1.5",
"@types/debug": "4.1.7",
Expand Down Expand Up @@ -50,7 +51,6 @@
"jest": "28.1.0",
"jest-environment-jsdom": "28.1.0",
"mini-css-extract-plugin": "2.6.0",
"playwright": "1.29.2",
"prettier": "2.6.2",
"purgecss-webpack-plugin": "4.1.3",
"sass": "1.51.0",
Expand Down

0 comments on commit 994155b

Please sign in to comment.