Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Annotations needs to be on all resources #15

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

sl1pm4t
Copy link
Contributor

@sl1pm4t sl1pm4t commented Nov 27, 2024

Otherwise sync wave will not include all resources required to deploy Kafka.

Otherwise sync wave will not include all resources required to deploy Kafka.
Copy link

Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 kafka => (version: "0.3.2", path: "charts/kafka")
------------------------------------------------------------------------------------------------------------------------

Saving 0 charts
Deleting outdated charts
Linting chart "kafka => (version: \"0.3.2\", path: \"charts/kafka\")"
Checking chart "kafka => (version: \"0.3.2\", path: \"charts/kafka\")" for a version bump...
Old chart version: 0.3.1
New chart version: 0.3.2
Chart version ok.
Validating /__w/helm-charts/helm-charts/charts/kafka/Chart.yaml...
Validation success! 👍

### Chart [ kafka ] charts/kafka

 PASS  Kafka	charts/kafka/tests/kafka-nodepool_test.yaml
 PASS  Kafka	charts/kafka/tests/kafka_test.yaml

Charts:      1 passed, 1 total
Test Suites: 2 passed, 2 total
Tests:       5 passed, 5 total
Snapshot:    0 passed, 0 total
Time:        34.450874ms

==> Linting charts/kafka
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ kafka => (version: "0.3.2", path: "charts/kafka")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

@sl1pm4t sl1pm4t merged commit 890d9f0 into main Nov 27, 2024
1 check passed
@sl1pm4t sl1pm4t deleted the kafka-annotations-everywhere branch November 27, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants