Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Enhance Identity Configuration Flow #159

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
3f1d1e0
DittoManager initializes with platform-specific persistenceDirectory
rdas-ditto Oct 9, 2024
f1772ad
Fixed UI clipping on tvOS
rdas-ditto Oct 9, 2024
47dccfe
Code tidy
rdas-ditto Oct 9, 2024
eef6f19
Added Ditto logo mark
rdas-ditto Oct 9, 2024
a0f7b48
Refactor
rdas-ditto Nov 11, 2024
3e1c226
Merge branch 'main' into fix/153-apple-tv
rdas-ditto Nov 11, 2024
3fa39ca
Added offline token for Shared Identity type
rdas-ditto Nov 12, 2024
241084f
cleanup
rdas-ditto Nov 12, 2024
eedd934
Merge branch 'main' into fix/153-apple-tv
rdas-ditto Nov 12, 2024
156ed07
Continued refactoring, added form validation to Identity Configuration.
rdas-ditto Nov 27, 2024
a28efac
Adjusted layout of paste button on input text field.
rdas-ditto Nov 27, 2024
e35a1a9
Added comments for DittoIdentity+Extension.swift
rdas-ditto Nov 27, 2024
ddd3481
Added comments for KeychainService.swift
rdas-ditto Nov 27, 2024
385a216
Updated tvOS logic and UI for consistency. Added comments.
rdas-ditto Nov 27, 2024
958c6c8
Added Ditto is active / not running to tvOS interface.
rdas-ditto Nov 27, 2024
c15c8a8
Restored LoggingDetailsView to working order; updated ExportData.
rdas-ditto Nov 28, 2024
feeac28
Side mission to get LoggingDetailsView compiling and working correctl…
rdas-ditto Dec 12, 2024
ba281cd
Cleanup on DittoService
rdas-ditto Dec 12, 2024
0aa385c
Added SyncButton
rdas-ditto Dec 12, 2024
b70c2f9
Pass ditto instance to LoggingDetailsViewer
rdas-ditto Dec 12, 2024
0a33d78
Disabled Cancel button if no Configuration is available. Resolved war…
rdas-ditto Dec 12, 2024
4dc0223
Cleaning up DittoService
rdas-ditto Dec 13, 2024
3aea3fc
Added documentation for Authentication Delegate
rdas-ditto Dec 13, 2024
6cabd65
Moved AllToolsMenu UI components into their own files and group
rdas-ditto Dec 13, 2024
5238051
Improved documentation for Identity Configuration Service
rdas-ditto Dec 13, 2024
2b3c5c0
Refactored IdentityConfigurationView for multiplatform
rdas-ditto Dec 13, 2024
f7f9dbc
SyncButton interfaces with DittoService, simplified SyncButton animat…
rdas-ditto Dec 16, 2024
f6f5f5d
Added DocC and comments to DittoService
rdas-ditto Dec 16, 2024
b0cde34
Improved separation of concerns
rdas-ditto Dec 17, 2024
6c4d9c6
Refactored “Identity Configuration” to “Credentials” for clarity.
rdas-ditto Dec 17, 2024
ce3c7b9
Updated Display Name, and App Icon Assets
rdas-ditto Dec 17, 2024
354a3b7
Renamed IdentityForm to FormView, along with ViewModel, InputData and…
rdas-ditto Dec 17, 2024
65e2c37
Combined SupplementalCredentials into the new Credentials object
rdas-ditto Dec 17, 2024
7fd24fa
Added keys symbol svg to Assets Catalog, as it is only available in i…
rdas-ditto Dec 17, 2024
656f2e3
Simplified MenuView which no longer needs to take a title param
rdas-ditto Dec 17, 2024
0c36898
Fixed the Identity type picker to be more consistent across platforms.
rdas-ditto Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
244 changes: 142 additions & 102 deletions DittoToolsApp/DittoToolsApp.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

5 changes: 2 additions & 3 deletions DittoToolsApp/DittoToolsApp/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
//
// DittoMessagesApp.swift
// DittoMessages
// AppDelegate.swift
//
// Created by Maximilian Alexander on 7/18/22.
// Copyright © 2024 DittoLive Incorporated. All rights reserved.
//

import SwiftUI
Expand Down
200 changes: 0 additions & 200 deletions DittoToolsApp/DittoToolsApp/AppSettings.swift

This file was deleted.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
{
"images" : [
{
"filename" : "Artwork - Light.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"filename" : "Artwork - Dark.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "tinted"
}
],
"filename" : "Artwork - Tinted.png",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"info" : {
"author" : "xcode",
"version" : 1
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"images" : [
{
"filename" : "Ditto.LogoMark.Blue.svg",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
},
"properties" : {
"preserves-vector-representation" : true,
"template-rendering-intent" : "template"
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading