Skip to content

Commit

Permalink
FEATURE: exclude terminating node from alb target (#185)
Browse files Browse the repository at this point in the history
getamis/terraform-aws-asg-lifecycle#5
To prevent 502/504 errors when worker node is terminating, remove the
node from the ALB target group before termination.
  • Loading branch information
Downager authored Mar 15, 2024
1 parent a50ffd9 commit 1c1e27f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/aws/kube-master/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ resource "aws_launch_template" "master" {

module "lifecycle_hook" {
count = var.enable_asg_life_cycle ? 1 : 0
source = "git::ssh://[email protected]/getamis/terraform-aws-asg-lifecycle//modules/kubernetes?ref=v1.27.4.0"
source = "git::ssh://[email protected]/getamis/terraform-aws-asg-lifecycle//modules/kubernetes?ref=v1.27.4.1"

name = "${var.name}-master"
cluster_name = var.name
Expand Down
2 changes: 1 addition & 1 deletion modules/aws/kube-worker/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ resource "aws_launch_template" "worker" {

module "lifecycle_hook" {
count = var.enable_asg_life_cycle ? 1 : 0
source = "git::ssh://[email protected]/getamis/terraform-aws-asg-lifecycle//modules/kubernetes?ref=v1.27.4.0"
source = "git::ssh://[email protected]/getamis/terraform-aws-asg-lifecycle//modules/kubernetes?ref=v1.27.4.1"

name = "${var.name}-worker-${var.instance_config["name"]}"
cluster_name = var.name
Expand Down

0 comments on commit 1c1e27f

Please sign in to comment.