Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Dataset[BinaryTile] so generated MVTs can be stored in a single output #100

Closed
wants to merge 3 commits into from

Conversation

mojodna
Copy link
Collaborator

@mojodna mojodna commented Jun 24, 2019

Overview

This is in addition to (optionally) writing individual MVTs out. This will save on object management and time taken to PUT individual tiles.

The single output contained generated MVTs can be subsequently processed to extract specific tiles or to write to an alternate data sink (e.g. MBTiles (#51)).

Checklist

  • Add entry to CHANGELOG.md

This is in addition to (optionally) writing individual MVTs out. This
will save on object management and time taken to PUT individual tiles.
@mojodna mojodna changed the title Return Dataset[BinaryTile] Return Dataset[BinaryTile] so generated MVTs can be stored in a single output Jun 24, 2019
@jpolchlo
Copy link
Contributor

jpolchlo commented Jul 9, 2019

I approve of this concept. Would be good for benchmarking purposes as well to cut out the costly write operation. Would love to see if we can come up with a way to generate an MBTiles file out of one of these Dataset[BinaryTile] guys.

@jpolchlo
Copy link
Contributor

jpolchlo commented Jul 9, 2019

Oh, but, we should hold off on deploying this until after 1.0.0

@jpolchlo
Copy link
Contributor

This (I think) has been obviated by #140. Reopen if that's not true.

@jpolchlo jpolchlo closed this Jun 10, 2021
@mojodna
Copy link
Collaborator Author

mojodna commented Jul 7, 2021

👋 Not quite (as far as I can imagine). I can imagine using finalize to output a single file(set) per zoom, but returning Unit from the end of the pipeline makes it difficult (impossible?) to accumulate (ideally lazily and optionally) all of the tiles for all of the zooms into a single data frame (and potentially re-group tiles from multiple zooms together).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants