Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add styleUrl to Placemark. #61

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Add styleUrl to Placemark. #61

merged 1 commit into from
Dec 22, 2024

Conversation

keltia
Copy link
Contributor

@keltia keltia commented Dec 12, 2024

Google Earth does add styleUrl to Placemark but it wasn't supported. Fix it.

pjsier
pjsier approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for catching this! This looks great, the lifetime isn't something you added so I'll merge this even though clippy is technically failing

@pjsier pjsier merged commit 4812420 into georust:main Dec 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjsier pjsier pjsier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keltia @pjsier