Styling updates #110
Styling updates #110
Conversation
…e to node_to_meta
| ): | ||
| print( | ||
| f"unexpected country provision: {provided} " | ||
| + self.node_to_meta.get(provided, {}).get("type", "") |
There was a problem hiding this comment.
Not blocking. The general trend in this file has been to convert printed warnings to assert statements. Should this also become an assert someday?
There was a problem hiding this comment.
Good point, opened an issue and will think about it more later
|
|
||
| import Header from "./header"; |
There was a problem hiding this comment.
Not blocking. Looks like this file is no longer being used anywhere. Should it be deleted?
| rev: 22.3.0 | ||
| hooks: | ||
| - id: black | ||
| language_version: python3.7 |
There was a problem hiding this comment.
Not blocking. While installing pre-commit just now, I ran into this issue.
I believe you said that for our airflow pipelines, we use python 3.8, which is what I have by default on my machine. We could change this to python3 to make it compatible for multiple python versions.
There was a problem hiding this comment.
I have this implemented in #127
There was a problem hiding this comment.
Ok cool -- can you make the change in this template repo too https://github.com/georgetown-cset/code-validation-template/issues/1
No description provided.