-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miscellaneous fixes to the French translation #998
base: main
Are you sure you want to change the base?
Conversation
@fvanderbiest now is the best time to improve the labels, it might be harder once the first release of the editor is out :) go ahead, thanks! |
All done from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fvanderbiest I must say I am a bit confused about some of the changes you suggest. I agree that users are mostly looking at the metadata and seeing the data. But it sometimes feels misleading. Mostly when we talk about editing. The data will never be updated alongside the metadata, yet we ask a confirmation to the user if he wants to update the dataset. Same for the external import. No data is created then, only metadata.
"editor.record.form.field.recordUpdated": "Record Updated", | ||
"editor.record.form.field.resourceUpdated": "Resource Updated", | ||
"editor.record.form.field.recordUpdated": "Dataset updated", | ||
"editor.record.form.field.resourceUpdated": "Resource updated", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't get this diff. In technical terms, the record is the metadata and the resource is the data, but here you suggest the data for the record.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
The notion of dataset encompasses data and their metadata.
See eg https://demo.ckan.org/dataset/warandpeace - the word "metadata" or "record" is nowhere to see.
See also https://stable.demo.geonode.org/catalogue/#/datasets?d=11161%3Bdataset%3Bvector
We make the difference between data and metadata because we're fully immersed in the technical context.
But for most users, this is too complex to grasp. We need to lower the barrier to entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. As discussed with @xxiiss , these metadata fields about the update date should not even be shown. We will remove those, and then your PR will be valid.
This PR replaces "Fiches de métadonnée" with "Jeux de données" (French term for "dataset", which is commonly used in the OpenData community, rather than "metadata sheet").
It also fixes several missing accentuated chars.
If accepted, all translation files should be updated accordingly.
I can take care of it. Just tell me if I should go ahead or not.