Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation / GeoNetwork 4.4 doing a release fixes #7648

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented Jan 22, 2024

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added this to the 4.4.2 milestone Jan 22, 2024
@josegar74 josegar74 requested a review from jodygarnett January 22, 2024 14:38
@josegar74 josegar74 added the Documentation Documentation writing & improvements label Jan 22, 2024
@josegar74 josegar74 force-pushed the fixes-doing-a-release-44 branch from c2f272e to a576b45 Compare January 22, 2024 14:41
@fxprunayre fxprunayre modified the milestones: 4.4.2, 4.4.3 Jan 23, 2024
Copy link
Member

@fxprunayre fxprunayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be good that at some point to point to a script which does it #7399

Copy link
Contributor

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I see how you have made use of variables.

I would like to volunteer to do the next release, and then indeed as @fxprunayre indicates automation would be good.

@josegar74 josegar74 merged commit da0852a into geonetwork:main Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation writing & improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants