-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support withheld to filter out elements defined in the schema filters configurations in Lucene query output #6897
Merged
josegar74
merged 7 commits into
geonetwork:3.12.x
from
GeoCat:withheld-improvements-312
Mar 17, 2023
Merged
Support withheld to filter out elements defined in the schema filters configurations in Lucene query output #6897
josegar74
merged 7 commits into
geonetwork:3.12.x
from
GeoCat:withheld-improvements-312
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegar74
changed the title
https://github.com/geonetwork/core-geonetwork/pull/6869
Support withheld to filter out elements defined in the schema filters configurations in Lucene query output
Mar 9, 2023
josegar74
force-pushed
the
withheld-improvements-312
branch
from
March 9, 2023 09:11
ffdfa3c
to
359229d
Compare
They are read-only. Can't be modified after the instance creation.
juanluisrp
requested changes
Mar 16, 2023
core/src/main/java/org/fao/geonet/kernel/schema/MetadataSchemaOperationFilter.java
Outdated
Show resolved
Hide resolved
@juanluisrp thanks for the review. I've added the changes suggested in 6fe41ca |
juanluisrp
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM.
josegar74
added a commit
to delwp-gn/core-geonetwork
that referenced
this pull request
Mar 17, 2023
… configurations in Lucene query output (geonetwork#6897) * Support withheld authenticated operation in the schema operation filters * MEF export - withheld elements in additional formats export * Fix iso19139 / iso19115-3.2008 filter operations xpath * Support withheld in Lucene query output * Make fields final They are read-only. Can't be modified after the instance creation. * Some minor changes * Remove unused constructor and create an enumeration for metadata schema operations --------- Co-authored-by: Juan Luis Rodríguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #6869, but for
3.12.x
to supportwithheld
filter elements in Lucene query output.Also includes:
authenticated
operation in metadata operation filters.iso19139
andiso19115-3.2008
schemas.A test case:
Create an ISO19115-3.2008 metadata with the template for geographical data.
Check the metadata default view, full view, pdf: all contacts should be displayed. The XML view should contain all the contact details.
Publish the metadata.
With an anonymous user or a logged user that can't edit the metadata, check the metadata default view, full view, pdf: only the Identification Info > Point of Contact (Contact for the resource) should be displayed. The XML view should contain the contact details for Identification Info > Point of Contact (Contact for the resource), for the others should contain the root element with the attribute
gco:nilReason=""withheld"
without containing the contact information.