Skip to content

Commit

Permalink
revise based on feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Jody Garnett <[email protected]>
  • Loading branch information
jodygarnett committed Jun 13, 2020
1 parent 82ad4ae commit 694edc7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ Thank you for contributing to GeoNetwork:

* Pull request is required, even if you have commit access, so the tests are run and other developer can check your code.

* Pull requests must be applied to `master`, before bing backported.
* Pull requests must be applied to `master`, before being backported.

* Good housekeeping: Anytime you commit, try and clean the code around it to latest style guide. If you improve a function without comments: add comments. If you modify functionality that does not have tests: write a test. If you fix functionality without documentation: add documentation.

* History: Clean commit messages and history: avoid big commits with hundreds of files, break commits commits up into understandable chunks, longer verbose commit messages are encouraged.
* History: Clean commit messages and history: avoid big commits with hundreds of files, break commits commits up into understandable chunks, longer verbose commit messages are encouraged. Beware of reformatting and needless whitespace changes.

* Draft: Use pull request *Draft** (or even the text "WIP") to identify work in progress.

Expand Down

0 comments on commit 694edc7

Please sign in to comment.