Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luisfpereira
Copy link
Collaborator

This PR updates dependencies.

In particular, it:

  • adds torch, torch-sparse, torch-scatter, and torch-geometric

  • removes unused dependencies (some of which I believe are dependencies of the packages this depends upon; installation should then be done through those)

  • adds tutorial as an optional dependency type containing libraries that are only relevant for tutorials

Linting of the file is done automatically using Even Better Toml.

@levtelyatnikov
Copy link
Collaborator

One question regarding the dependencies: shouldn't we specify the exact version of each library we use? My primary concern is torch_geometric as it updates often and not always with backward compatibility

@luisfpereira
Copy link
Collaborator Author

@levtelyatnikov, personally I try to keep the code always working with the latest release of a given package (especially the most relevant ones).
This is supported by the fact the latest release of a package is (supposedly) better and more bug free.

When that is not possible, I agree specifying the version is a good practice, though it increases the possibility the package becomes incompatible with some other (the same may happen if we update and others not, but it that case, ours is not the outdated package).

I guess the guidelines may vary among communities though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants