-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for creating tile layers #6
Conversation
QGIS's power lies for a big part in its plugin system. One of the most popular QGIS plugins is QuickMapServices (over 5M downloads), which allows adding basemaps and geoservices. |
FWIW, Felt has a QGIS plugin which allows to export QGIS projects to new maps in felt.com. Maybe that's something we should look at. |
@davidbrochart thanks for commenting this. I don't think it's related to this PR though. Could you open issues with your comments? |
What I mean is that this PR is taking a direction which already diverges from the QGIS model. Shouldn't we first discuss these architectural questions? |
How does this PR in particular diverges from the QGIS model?
This is perfectly fine, and I believe we'll be able to achieve the same kind of designs thanks to the lumino plugin system
Yes definitely, it's part of the plan to support importing But again I don't think any of this is related to this PR in particular. This PR merely adds simple tile layers support in the |
OK, I guess I was confused by the JGIS/QGIS split, where QGIS projects can be imported to JGIS, and JGIS projects can be exported to QGIS. But JupyterGIS won't directly work on QGIS projects, right? |
Right. The plan is to have our own JSON-based format so that's easy to use for collaboration.
Yes we should definitely do that 👍🏽 Also we probably want to start implementing the interface between QGIS/JGIS early so that we make the proper decisions on the JGIS format. Concerning the plugin system, it's also part of the plan to implement an equivalent of the plugin https://enmap-box.readthedocs.io/en/latest/general/about.html, probably shipped as a plugin to jupytergis. |
740bf87
to
e9a4dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martinRenou, LGTM
Defining basic tile layers.
To do:
Provide a set of tile layers by default https://github.com/geopandas/xyzservices/blob/main/xyzservices/data/providers.json (Will be done later in a separate PR)Screencast.from.2024-06-13.13-29-20.mp4