Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for creating tile layers #6

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jun 13, 2024

Defining basic tile layers.

To do:

Screencast.from.2024-06-13.13-29-20.mp4

Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/tilelayer_schema

@davidbrochart
Copy link
Collaborator

QGIS's power lies for a big part in its plugin system. One of the most popular QGIS plugins is QuickMapServices (over 5M downloads), which allows adding basemaps and geoservices.
If we're going to model JupyterGIS after QGIS, shouldn't we start adopting the same plugin architecture?

@davidbrochart
Copy link
Collaborator

FWIW, Felt has a QGIS plugin which allows to export QGIS projects to new maps in felt.com. Maybe that's something we should look at.

@martinRenou
Copy link
Member Author

@davidbrochart thanks for commenting this. I don't think it's related to this PR though. Could you open issues with your comments?

@davidbrochart
Copy link
Collaborator

What I mean is that this PR is taking a direction which already diverges from the QGIS model. Shouldn't we first discuss these architectural questions?

@martinRenou
Copy link
Member Author

What I mean is that this PR is taking a direction which already diverges from the QGIS model

How does this PR in particular diverges from the QGIS model?

power lies for a big part in its plugin system. One of the most popular QGIS plugins is QuickMapServices (over 5M downloads), which allows adding basemaps and geoservices

This is perfectly fine, and I believe we'll be able to achieve the same kind of designs thanks to the lumino plugin system

FWIW, Felt has a QGIS plugin which allows to export QGIS projects to new maps in felt.com

Yes definitely, it's part of the plan to support importing .qgis xml files. We've done something similar with JupyterCAD and freecad with https://github.com/jupytercad/jupytercad-freecad

But again I don't think any of this is related to this PR in particular. This PR merely adds simple tile layers support in the .jgis format.

@davidbrochart
Copy link
Collaborator

OK, I guess I was confused by the JGIS/QGIS split, where QGIS projects can be imported to JGIS, and JGIS projects can be exported to QGIS. But JupyterGIS won't directly work on QGIS projects, right?
Maybe we could set up a test suite that will check that a QGIS project is importable in JGIS, and a JGIS project is exportable to QGIS, where applicable?

@martinRenou
Copy link
Member Author

But JupyterGIS won't directly work on QGIS projects, right?

Right. The plan is to have our own JSON-based format so that's easy to use for collaboration.

Maybe we could set up a test suite that will check that a QGIS project is importable in JGIS, and a JGIS project is exportable to QGIS, where applicable?

Yes we should definitely do that 👍🏽

Also we probably want to start implementing the interface between QGIS/JGIS early so that we make the proper decisions on the JGIS format.

Concerning the plugin system, it's also part of the plan to implement an equivalent of the plugin https://enmap-box.readthedocs.io/en/latest/general/about.html, probably shipped as a plugin to jupytergis.

@martinRenou martinRenou added the enhancement New feature or request label Jun 20, 2024
@martinRenou martinRenou requested a review from brichet June 20, 2024 13:46
@martinRenou martinRenou marked this pull request as ready for review June 20, 2024 13:48
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martinRenou, LGTM

@brichet brichet merged commit b5fed91 into geojupyter:main Jun 20, 2024
8 checks passed
@martinRenou martinRenou deleted the tilelayer_schema branch June 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants