-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector tile source #37
Conversation
e373e53
to
fd12bbe
Compare
fd12bbe
to
dd282ad
Compare
Maybe we could build a gallery of vector tile sources too, if we find enough free sources |
please update snapshots |
Triggering CI |
Thanks @martinRenou To fix the right panel form we should change the selection of layer and source type here: with something like: if (selectedObj.type === 'RasterLayer') {
SourceForm = RasterSourcePropertiesForm;
} else if (selectedObj.type === 'VectorLayer') {
LayerForm = VectorLayerPropertiesForm;
}
if (selectedObjSource.type === 'GeoJSONSource') {
SourceForm = GeoJSONSourcePropertiesForm;
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks.
It may wait a follow up PR but we should:
- change the icon of the
newGeoJSONLayer
command (the icon already exist) (EDIT: already mentioned here) - refactor the
GeoJSONLayerDialog
to be aVectorLayerDialog
, with the parameters from the vector layer schema and the specific parameters from the source (GeoJSON, Vector tile...)
} | ||
}; | ||
|
||
const dialog = new FormDialog({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no parameters about the vector layer (color, opacity...)
We can fix it with the suggestion above, about refactoring the GeoJSONLayerDialog
Thanks for the review!
Yes, actually the official GeoJSON icon could suit best for the |
Screencast.from.2024-07-15.17-25-51.mp4