Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector tile source #37

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jul 11, 2024

Screencast.from.2024-07-15.17-25-51.mp4

@martinRenou martinRenou added the enhancement New feature or request label Jul 11, 2024
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/jupytergis/vector_tile_source

@martinRenou martinRenou force-pushed the vector_tile_source branch 2 times, most recently from e373e53 to fd12bbe Compare July 15, 2024 15:25
@martinRenou martinRenou changed the title Draft: Vector tile source Vector tile source Jul 15, 2024
@martinRenou martinRenou requested a review from brichet July 15, 2024 15:28
@martinRenou
Copy link
Member Author

Maybe we could build a gallery of vector tile sources too, if we find enough free sources

@martinRenou
Copy link
Member Author

please update snapshots

@martinRenou
Copy link
Member Author

Triggering CI

@martinRenou martinRenou reopened this Jul 16, 2024
@brichet
Copy link
Collaborator

brichet commented Jul 16, 2024

Thanks @martinRenou

To fix the right panel form we should change the selection of layer and source type here:
https://github.com/QuantStack/jupytergis/blob/e52fe9f6db97e80a24813ca0c2957b1df364fde8/packages/base/src/panelview/objectproperties.tsx#L240-L245

with something like:

    if (selectedObj.type === 'RasterLayer') {
      SourceForm = RasterSourcePropertiesForm;
    } else if (selectedObj.type === 'VectorLayer') {
      LayerForm = VectorLayerPropertiesForm;
    }

    if (selectedObjSource.type === 'GeoJSONSource') {
      SourceForm = GeoJSONSourcePropertiesForm;
    }

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks.

It may wait a follow up PR but we should:

  • change the icon of the newGeoJSONLayer command (the icon already exist) (EDIT: already mentioned here)
  • refactor the GeoJSONLayerDialog to be a VectorLayerDialog, with the parameters from the vector layer schema and the specific parameters from the source (GeoJSON, Vector tile...)

}
};

const dialog = new FormDialog({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no parameters about the vector layer (color, opacity...)

We can fix it with the suggestion above, about refactoring the GeoJSONLayerDialog

@martinRenou
Copy link
Member Author

Thanks for the review!

change the icon of the newGeoJSONLayer command (the icon already exist)

Yes, actually the official GeoJSON icon could suit best for the newGeoJSONLayer command

@martinRenou martinRenou merged commit c2058ea into geojupyter:main Jul 16, 2024
9 checks passed
@martinRenou martinRenou deleted the vector_tile_source branch July 16, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants