Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodata to geotiff source #198

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Nov 6, 2024

Addresses one of the issues mentioned in #196. Adds nodata attribute to source info when creating geotiff sources so no black box is displayed. Potentially this option could be added to the schema and exposed on the creation form instead.

no_box

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/add_nodata_to_geotiff_source

@gjmooney gjmooney added the bug Something isn't working label Nov 6, 2024
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!+1 for adding it to the schema

@martinRenou martinRenou merged commit e8c5b1e into geojupyter:main Nov 6, 2024
9 of 11 checks passed
@gjmooney gjmooney deleted the add_nodata_to_geotiff_source branch November 6, 2024 11:12
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Preview PR at appsharing.space

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Integration tests repot: appsharing.space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants