-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color ramps and classification #177
Color ramps and classification #177
Conversation
7228014
to
304bcf4
Compare
7b11855
to
ddd24c9
Compare
Just rebased! |
Preview PR at appsharing.space |
Integration tests repot: appsharing.space |
Yea we could do that. This comment made me realize there's an issue, if you open the symbology panel before the band data is in |
ddd24c9
to
65f6d4c
Compare
087fee1
to
2dbde22
Compare
The colormap names are not visible when using the light theme. I guess we should not use CSS variables for those but harcoded white? Sometimes it stops showing the color ramp that was used for generating the color stops (e.g. when closing the symbology panel and reopening it). I wonder if it would make sense to store the colormap type in the schema so that it's easier for you to restore the state of the symbology panel? |
👍
Yea I was debating whether to save that stuff in the schema instead of |
9cc9e4c
to
c025aa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!!! 🚀
Implementing #173
I started to add automatic data classification and color ramps. I still need to add other classification methods, add it to other render types, and work on the UI a bit.