Use extent instead of center position and zoom #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks Nicolas! This requires a rebase now that Greg's switch to Open Layers has been merged |
martinRenou
approved these changes
Sep 6, 2024
| ) | ||
|
|
||
| from jupytergis_lab.notebook.utils import get_source_layer_names | ||
|
|
||
|
|
||
| # Part of this code is copied from https://github.com/felt/qgis-plugin (GPL-2.0 license) | ||
| class MapUtils: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR use the extent (viewport in latitude/longitude) instead of the center and zoom.
This simplifies computation when using QGIS files, and is available in most of the viewers.
The zoom value is kept (but not computed server side) because it seems to be useful for the filters.