Remove versioning PR #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the versioning workflow where a PR would be created to "version" the application. This was proving difficult to wrangle, with extra notes going into the GitHub release when they shouldn't, plus it relied on the default label being set to one that didn't bump a version which felt wrong.
When a PR is merged that will bump a new version this will happen straight away and the changelog will be updated in a commit as part of that workflow. Not quiet ideal, but ok for the moment. Could always force the use of a
releaselabel on a PR if needed but will see how it goes.