Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for new command #31

Merged
merged 11 commits into from
Nov 20, 2024
Merged

Adds tests for new command #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
24a5243
Wip adding tests for list stacks command
geofflamrock Nov 18, 2024
9511405
Fix tests
geofflamrock Nov 18, 2024
7cfd0c6
Less chance of collision in tests
geofflamrock Nov 18, 2024
bbd804a
Add tests to CI
geofflamrock Nov 18, 2024
014c1fd
Update FluentAssertions
geofflamrock Nov 18, 2024
1e6619a
Merge branch 'main' into list-stacks-tests
geofflamrock Nov 18, 2024
90a15cc
Add tests for new stack command
geofflamrock Nov 19, 2024
fbbfcc1
Make test paths work on windows
geofflamrock Nov 20, 2024
5397318
Attempt to fix it in the test reporter instead
geofflamrock Nov 20, 2024
f92024f
Merge branch 'list-stacks-tests' into new-stack-tests
geofflamrock Nov 20, 2024
e926291
Merge branch 'main' into new-stack-tests
geofflamrock Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
365 changes: 365 additions & 0 deletions src/Stack.Tests/Commands/Stack/NewStackCommandHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,365 @@
using FluentAssertions;
using NSubstitute;
using Stack.Commands;
using Stack.Config;
using Stack.Git;
using Stack.Tests.Helpers;

namespace Stack.Tests.Commands.Stack;

public class NewStackCommandHandlerTests
{
[Fact]
public async Task WithANewBranch_AndSwitchingToTheBranch_TheStackIsCreatedAndTheCurrentBranchIsChanged()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
inputProvider.ConfirmAddOrCreateBranch().Returns(true);
inputProvider.SelectAddOrCreateBranch().Returns(BranchAction.Create);
inputProvider.GetNewBranchName().Returns("new-branch");
inputProvider.ConfirmSwitchToBranch().Returns(true);

// Act
var response = await handler.Handle(NewStackCommandInputs.Empty, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", BranchAction.Create, "new-branch"));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", ["new-branch"])
});

gitOperations.Received().ChangeBranch("new-branch", Arg.Any<GitOperationSettings>());
}

[Fact]
public async Task WithAnExistingBranch_AndSwitchingToTheBranch_TheStackIsCreatedAndTheCurrentBranchIsChanged()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
inputProvider.ConfirmAddOrCreateBranch().Returns(true);
inputProvider.SelectAddOrCreateBranch().Returns(BranchAction.Add);
inputProvider.GetBranchToAdd(Arg.Any<string[]>()).Returns("branch-2");
inputProvider.ConfirmSwitchToBranch().Returns(true);

// Act
var response = await handler.Handle(NewStackCommandInputs.Empty, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", BranchAction.Add, "branch-2"));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", ["branch-2"])
});

gitOperations.Received().ChangeBranch("branch-2", Arg.Any<GitOperationSettings>());
}

[Fact]
public async Task WithNoBranch_TheStackIsCreatedAndTheCurrentBranchIsNotChanged()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
inputProvider.ConfirmAddOrCreateBranch().Returns(false);

// Act
var response = await handler.Handle(NewStackCommandInputs.Empty, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", null, null));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", [])
});

gitOperations.DidNotReceive().ChangeBranch(Arg.Any<string>(), Arg.Any<GitOperationSettings>());
}

[Fact]
public async Task WithANewBranch_AndNotSwitchingToTheBranch_TheStackIsCreatedAndTheCurrentBranchIsNotChanged()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
inputProvider.ConfirmAddOrCreateBranch().Returns(true);
inputProvider.SelectAddOrCreateBranch().Returns(BranchAction.Create);
inputProvider.GetNewBranchName().Returns("new-branch-1");
inputProvider.ConfirmSwitchToBranch().Returns(false);

// Act
var response = await handler.Handle(NewStackCommandInputs.Empty, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", BranchAction.Create, "new-branch-1"));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", ["new-branch-1"])
});

gitOperations.DidNotReceive().ChangeBranch("new-branch-1", Arg.Any<GitOperationSettings>());
}

[Fact]
public async Task WithAnExistingBranch_AndNotSwitchingToTheBranch_TheStackIsCreatedAndTheCurrentBranchIsNotChanged()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
inputProvider.ConfirmAddOrCreateBranch().Returns(true);
inputProvider.SelectAddOrCreateBranch().Returns(BranchAction.Add);
inputProvider.GetBranchToAdd(Arg.Any<string[]>()).Returns("branch-2");
inputProvider.ConfirmSwitchToBranch().Returns(false);

// Act
var response = await handler.Handle(NewStackCommandInputs.Empty, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", BranchAction.Add, "branch-2"));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", ["branch-2"])
});

gitOperations.DidNotReceive().ChangeBranch("branch-2", Arg.Any<GitOperationSettings>());
}

[Fact]
public async Task WhenStackNameIsProvidedInInputs_TheProviderIsNotAskedForAName_AndTheStackIsCreatedWithTheName()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
inputProvider.ConfirmAddOrCreateBranch().Returns(false);

var inputs = new NewStackCommandInputs("Stack1", null, null);

// Act
var response = await handler.Handle(inputs, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", null, null));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", [])
});

inputProvider.DidNotReceive().GetStackName();
}

[Fact]
public async Task WhenSourceBranchIsProvidedInInputs_TheProviderIsNotAskedForTheBranch_AndTheStackIsCreatedWithTheSourceBranch()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.ConfirmAddOrCreateBranch().Returns(false);

var inputs = new NewStackCommandInputs(null, "branch-1", null);

// Act
var response = await handler.Handle(inputs, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", null, null));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", [])
});

inputProvider.DidNotReceive().GetSourceBranch(Arg.Any<string[]>());
}

[Fact]
public async Task WhenBranchNameIsProvidedInInputs_TheProviderIsNotAskedForTheBranchName_AndTheStackIsCreatedWithTheBranchName()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
// Note there shouldn't be any more inputs required at all

var inputs = new NewStackCommandInputs(null, null, "new-branch");

// Act
var response = await handler.Handle(inputs, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", BranchAction.Create, "new-branch"));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", ["new-branch"])
});

inputProvider.Received().GetStackName();
inputProvider.Received().GetSourceBranch(Arg.Any<string[]>());
inputProvider.ClearReceivedCalls();
inputProvider.ReceivedCalls().Should().BeEmpty();
}

[Fact]
public async Task WhenAllInputsAreProvided_TheProviderIsNotAskedForAnything_AndTheStackIsCreatedCorrectly()
{
// Arrange
var gitOperations = Substitute.For<IGitOperations>();
var stackConfig = Substitute.For<IStackConfig>();
var inputProvider = Substitute.For<INewStackCommandInputProvider>();
var handler = new NewStackCommandHandler(inputProvider, gitOperations, stackConfig);

var remoteUri = Some.HttpsUri().ToString();

gitOperations.GetRemoteUri(Arg.Any<GitOperationSettings>()).Returns(remoteUri);
gitOperations.GetLocalBranchesOrderedByMostRecentCommitterDate(Arg.Any<GitOperationSettings>()).Returns(["branch-1", "branch-2"]);

var stacks = new List<Config.Stack>();
stackConfig.Load().Returns(stacks);
stackConfig
.WhenForAnyArgs(s => s.Save(Arg.Any<List<Config.Stack>>()))
.Do(ci => stacks = ci.ArgAt<List<Config.Stack>>(0));

inputProvider.GetStackName().Returns("Stack1");
inputProvider.GetSourceBranch(Arg.Any<string[]>()).Returns("branch-1");
// Note there shouldn't be any more inputs required at all

var inputs = new NewStackCommandInputs("Stack1", "branch-1", "new-branch");

// Act
var response = await handler.Handle(inputs, CancellationToken.None);

// Assert
response.Should().BeEquivalentTo(new NewStackCommandResponse("Stack1", "branch-1", BranchAction.Create, "new-branch"));
stacks.Should().BeEquivalentTo(new List<Config.Stack>
{
new("Stack1", remoteUri, "branch-1", ["new-branch"])
});

inputProvider.ReceivedCalls().Should().BeEmpty();
}
}
Loading
Loading