Introduce ExtJS 5 example app #352

chrismayer · 2015-04-24T15:57:09Z

This PR introduces an ExtJS 5 based example app.
The new example app is an ExtJS5-MVVM port of the existing MVC-example app. The port is not exactly one-by-one, but the output is very very similar to the MVC app.

The base structure has been created with Sencha Cmd and therefore it is compatible for the usage with Cmd. No compiled sources are included here because they can be easily generated with Sencha Cmd. So code redundancy is avoided.

At the moment the GeoExt package dependency is not resolved automatically. The developer has to clone the GeoExt project into the packages folder of the app on his local checkout of this example.

Steps after checking out this branch:

Install Sencha Cmd 5.1 (http://docs.sencha.com/cmd/5.x/intro_to_cmd.html#System_Setup) if not installed on your system
Navigate to examples/app-mvvm/packages/ and execute git clone https://github.com/geoext/geoext2.git GeoExt
Navigate to examples/app-mvvm/ and execute sencha app watch
Open http://localhost:1841/ in a browser

According to the discussion in #351 this seems not be final now, but I suggest to review this to have a start point we can work with.

marcjansen · 2015-04-27T05:24:49Z

After I checkout the branch, what steps am I supposed to do to see the example? Is tehre some sencha command that I need to run? I am a total noob with regard to sencha, sorry.

Other remarks from the top of my head:

Can we have it just like we had it with the old app-example, so that there is a index.html loading the compiled file and a index-dev.html loading loads of single files?
examples.json needs to have an entry for this example

marcjansen · 2015-04-27T05:28:03Z

examples/app-mvvm/app/view/main/Main.js

+ * "autoCreateViewport" property. That setting automatically applies the "viewport"
+ * plugin to promote that instance of this class to the body element.
+ *
+ * TODO - Replace this content of this view to suite the needs of your application.


⇧ Can be removed, right?

marcjansen · 2015-04-27T05:37:37Z

I added a couple of other thoughts. Once I know how to look at this, I'll have another look. Thanks for the work so far on this, @chrismayer. I definitely want such an example in the library!

chrismayer · 2015-04-28T14:09:14Z

Hi @bentrm and @marcjansen,
thanks for your reviews!
I tried to adress your remarks (where possible). Would be cool, if you could have another look.
I also added some steps to get the app running for dev purposes to the PR description.

Can we have it just like we had it with the old app-example, so that there is a index.html loading the compiled file and a index-dev.html loading loads of single files?

I am not sure if this is way to go with Sencha Cmd. It seems that you get your dev-setup by running sencha app watch, which starts you a webserver, which automatically restarts in case of changing the source files.

examples.json needs to have an entry for this example

I will go for this later on.

bentrm · 2015-04-28T19:43:33Z

examples/app-mvvm/app.json

+     */
+    "js": [
+        {
+            "path": "http://cdn.sencha.com/ext/gpl/5.1.0/build/ext-all-rtl-debug.js"


Is this a "right-to-left" build of Ext? I think this can be omitted for development all together an the microloader will pick up your local Ext files.

My intention for this was to have solved the ExtJS dependency by a CDN resource, like it is done in the other examples. So you do not need a local copy of ExtJS.
You are right, this is a "right-to-left" build. This surely can be changed to the normal debug version of Ext.

bentrm · 2015-04-28T19:55:47Z

I added some comments inline. Having a look at your work, I added support to build the app without recursively cloning GeoExt into the examples packages folder. Would you be ok with me sending a PR to your working branch?

marcjansen · 2015-04-28T21:47:38Z

Just cherry picking such a commit would probably be easier and would result in a nicer history. Just my two cents.

chrismayer · 2015-05-07T06:56:34Z

@bentrm thanks a lot for your ongoing effort. Feel free to modify the branch. As @marcjansen suggested maybe cherry-picking would be a good option.

marcjansen · 2015-05-18T06:45:33Z

WRT to cherry picking: simply publish your commits somewhere @bentrm, @chrismayer can then cherry-pick them if he likes them.

bentrm · 2015-05-19T17:31:43Z

Hi @chrismayer, @marcjansen, I just pushed to 4e9852d.
It should be possible to run sencha app watch and sencha app build inside of the app folder of the environment that you have described above without recursively cloning GeoExt into the example app folder.

I also removed the Sass stuff as it hasn't been used in the example app (setting skip.sass=1 in .sencha/app/sencha.cfg) and changed the build output directory to the GeoExt root folder (see app.json) adding temp file and directories to .gitignore.

marcjansen · 2015-05-19T17:54:20Z

But this isn't a commit that builds on top of Chris' work, is it?

bentrm · 2015-05-19T18:50:02Z

It is, it may have diverged though: branch log

marcjansen · 2015-05-22T06:39:49Z

So the right diff is chrismayer:ext5-app...bentrm:ext5-app.

@chrismayer Any chance you can check it out?

chrismayer · 2015-07-27T10:37:04Z

I merged the changes of @bentrm.
@bentrm & @marcjansen can you have another look at this? TIA.

marcjansen · 2015-08-26T14:46:03Z

Good to be merged once the commit history is cleaned up. Thanks @chrismayer

This introduces the base setup for an ExtJS 5 based example app. The project structure is created with Sencha Cmd and the containing files are only the raw code files. No compiled sources are included here. The package dependency to GeoExt is also missing here to avoid redundancy. This will be solved by a later commit or the steps to resolve the GeoExt package dependency manually will be described in a README file.

@marcjansen

This adresses the review notes of @marcjansen and @bentrm: - Remove unnecessary files - Use xtypes for chart and grid declarations - Several code cleanups

…lder.

chrismayer · 2015-08-27T09:24:22Z

I cleaned the commit history a bit. So now this is good to go, will merge now. Thanks to anyone who was involved.

Introduce ExtJS 5 example app

marcjansen reviewed Apr 27, 2015
View reviewed changes

bentrm reviewed Apr 28, 2015
View reviewed changes

chrismayer mentioned this pull request May 12, 2015

Road to GeoExt 2.1.0 final #356

Closed

9 tasks

chrismayer and others added 5 commits August 27, 2015 11:14

Adress review notes for MVVM example app

99aaa72

This adresses the review notes of @marcjansen and @bentrm: - Remove unnecessary files - Use xtypes for chart and grid declarations - Several code cleanups

gitignore example builds and temp files in master.

88fed87

Move resources to designated folder.

78c6012

Add .sencha build structure to build example app in GeoExt package fo…

f60354e

…lder.

chrismayer force-pushed the ext5-app branch from e1d4171 to f60354e Compare August 27, 2015 09:15

chrismayer added a commit that referenced this pull request Aug 27, 2015

Merge pull request #352 from chrismayer/ext5-app

d10eaa2

Introduce ExtJS 5 example app

chrismayer merged commit d10eaa2 into geoext:master Aug 27, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce ExtJS 5 example app #352

Introduce ExtJS 5 example app #352

chrismayer commented Apr 24, 2015

marcjansen commented Apr 27, 2015

marcjansen Apr 27, 2015

marcjansen commented Apr 27, 2015

chrismayer commented Apr 28, 2015

bentrm Apr 28, 2015

chrismayer May 7, 2015

bentrm commented Apr 28, 2015

marcjansen commented Apr 28, 2015

chrismayer commented May 7, 2015

marcjansen commented May 18, 2015

bentrm commented May 19, 2015

marcjansen commented May 19, 2015

bentrm commented May 19, 2015

marcjansen commented May 22, 2015

chrismayer commented Jul 27, 2015

marcjansen commented Aug 26, 2015

chrismayer commented Aug 27, 2015

Introduce ExtJS 5 example app #352

Introduce ExtJS 5 example app #352

Conversation

chrismayer commented Apr 24, 2015

marcjansen commented Apr 27, 2015

marcjansen Apr 27, 2015

Choose a reason for hiding this comment

marcjansen commented Apr 27, 2015

chrismayer commented Apr 28, 2015

bentrm Apr 28, 2015

Choose a reason for hiding this comment

chrismayer May 7, 2015

Choose a reason for hiding this comment

bentrm commented Apr 28, 2015

marcjansen commented Apr 28, 2015

chrismayer commented May 7, 2015

marcjansen commented May 18, 2015

bentrm commented May 19, 2015

marcjansen commented May 19, 2015

bentrm commented May 19, 2015

marcjansen commented May 22, 2015

chrismayer commented Jul 27, 2015

marcjansen commented Aug 26, 2015

chrismayer commented Aug 27, 2015