Refactor command line interface #14
Conversation
hlokavarapu
force-pushed
the
call_new_CLI
branch
from
9b6c08d to
b1334b4
Compare
| import argparse | ||
| import os | ||
| import pprint | ||
| import re | ||
|
|
||
| import config_handling |
There was a problem hiding this comment.
Might as well remove this import too. utils/load_config.py is possibly a working replacement.
| @@ -54,7 +54,7 @@ def validate_config_stream(stream): | |||
| return valid_config | |||
|
|
|||
|
|
|||
| def load_config(proj_dir): | |||
| def load_config(proj_dir="."): | |||
There was a problem hiding this comment.
This doesn't need a default, does it? Just update the call in software_dmv.py.
There was a problem hiding this comment.
How then will a user specify a project path, proj_dir, different from the current working directory?
In other words, is there a CLI option to override this variable?
Thereby, I could call utils.load_config(path) vs utils.load_config(".")
There was a problem hiding this comment.
Not sure I understand what you're saying here. It sounds like you're arguing for removing the proj_dir argument entirely, since it probably won't be anything other than current directory.
My point was that, in terms of this utility function, assuming "." as a default makes more sense in software_dmv.py than in here.
| HEADER_IN_FIRST_N_LINES = 20 | ||
| HEADER_SIGNAL_STRING = "Copyright" | ||
|
|
||
| import license_handling | ||
|
|
There was a problem hiding this comment.
Since the new CLI doesn't use this file, changing it shouldn't be in this PR.
There was a problem hiding this comment.
Ideally, however, the file program_commands/check_command imports userfiles_handling which then wraps back to import userfiles_handling
For example,
Traceback (most recent call last):
File "software_dmv.py", line 8, in <module>
import program_commands.check_command as check_command
File "/home/harsha_lv/CIG_codes/cig_tools/Licensing_Program/program_commands/check_command.py", line 4, in <module>
import userfiles_handling
File "/home/harsha_lv/CIG_codes/cig_tools/Licensing_Program/userfiles_handling.py", line 10, in <module>
import license_handling
File "/home/harsha_lv/CIG_codes/cig_tools/Licensing_Program/license_handling.py", line 9, in <module>
import config_handling
File "/home/harsha_lv/CIG_codes/cig_tools/Licensing_Program/config_handling.py", line 28, in <module>
"maximum": userfiles_handling.HEADER_IN_FIRST_N_LINES,
AttributeError: module 'userfiles_handling' has no attribute 'HEADER_IN_FIRST_N_LINES'
The following functions are defined in userfiles_handling and are called in check_command module:
- userfile_handling.sanitize_path
- userfile_handling.userfiles_iter
- userfiles_handling.remove_ignored_userfiles
- userfiles_handling.commentfmt_userfiles_pairing
- userfiles_handling.match_header_in_file
There was a problem hiding this comment.
Darn. Okay, it's probably better to save removing this dependency for a different PR then.
|
This PR will resolve issue #8 once merged. |
hlokavarapu
force-pushed
the
call_new_CLI
branch
from
f419767 to
2d780b6
Compare
I have rewired the code to call the new command line interface @tjesser-ucdavis-edu .