Removal of Write(6,*) #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tukss
approved these changes
Aug 21, 2024
|
Great -- thanks for reviewing. I meant to note that using stdout%print in Input.F90 wasn't really possible (at least not in an easy way) since it can't be initialized until main_input is read. Until that file is read, we don't know if the user specified an output file or what its name was. That's why I left write(6,*) in Input.F90. Just wanted to make a note of that. Merging now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all calls to write(6,*) in the code that can be encountered during the course of a normal simulation. Instead, stdout%print is used, which is redirected to a log file, if desired. This change prevents a situation where some error message could be written out to standard out, whereas others would appear in the log file. Note that several references to write(6,*) have been retained. These are not encountered during normal usage of the code and can still be helpful for debugging. In addition, many references to write(6,*) which were commented out or unnecessary have been removed. This PR fixes issue #325 .